Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flake8 to CI and cleanup lint #41

Closed
djrtwo opened this issue Oct 13, 2017 · 2 comments
Closed

add flake8 to CI and cleanup lint #41

djrtwo opened this issue Oct 13, 2017 · 2 comments

Comments

@djrtwo
Copy link
Collaborator

djrtwo commented Oct 13, 2017

Issue

pylint is currently in our makefile but is not a part of CI. I would like like linting to ultimately be a part of tests passing/failing.

Proposed implementation

  • add flake8 to CI
  • cleanup repo to pep8 standards so CI passes
@zramsay
Copy link
Collaborator

zramsay commented Oct 13, 2017

this is basically #25 - yeah, i've started tackling some low hanging fruit on pylint.

@djrtwo
Copy link
Collaborator Author

djrtwo commented Oct 13, 2017

ah, missed that CI on #25
I'll close and reference flake8 there.

I'll be hitting the lint hard on any stuff I'm working on.

@djrtwo djrtwo closed this as completed Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djrtwo @zramsay