apply pylint and add to CI

[zramsay]

No description provided.

[djrtwo]

yes 100%

[djrtwo]

hey @zramsay, you going to be just doing review or will you be doing some dev too?

blockchain is our defacto branch until issue 26 is done. Assign yourself to an issue if you are going to pick it up.

Thanks for the issues/review :)

[zramsay]

haha yeah i discovered the "correct" branch. We should use master/develop once its merged. I'll be doing "light" dev work (e.g. tackling linting/useability/documentation, etc)

[djrtwo]

Cool! Agreed on master/develop.

[djrtwo]

I'll be focussing on organization and refactors for the time being. Probably one level deeper than you.

@naterush Will continue pushing the experimental dev -- oracles, simulations, etc.

[djrtwo]

Check out flake8. does lint+

[djrtwo]

I'm in favor of changing pylint settings to allow for line lengths up to 100 char instead of default 80. I work on a few python projects (web3.py, pyevm) that do this. Saves me a bit of headache and looks good on most screens.

Thoughts?

[karlfloersch]

@djrtwo I think it's totally reasonable to push the char limit up. The 80 char limit is too restrictive now that everyone has retina displays

[zramsay]

it's 100 by default already, at least when I run pylint.

[djrtwo]

Oh sweet! On mine too... My vim is just configured to 80.

…

On Fri, Oct 13, 2017 at 1:17 PM, Zach ***@***.***> wrote: it's 100 by default already, at least when I run pylint. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXf-6K0bMfkUUjnvWXESM5tTF3ahTG3ks5sr6lCgaJpZM4P0exW> .

[zramsay]

should we also pylint tests ?

[djrtwo]

i think so

…

On Sunday, October 15, 2017, Zach ***@***.***> wrote: should we also pylint tests ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXf-3aLkXGJs2xjj9S43DOFyqoJjz77ks5ssliGgaJpZM4P0exW> .

[naterush]

Closing. Will open new issue about getting CI working again.