[Issue 21] Migrate to pytest #30
Conversation
tests/test_safety_oracle.py
Outdated
| from testing_language import TestLangCBC | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
@naterush We can parametrize all of the tests in this file in the following format. On the one hand, it is great for code reuse. On the other, it makes it a little more nebulous as to what the crazy test string relates to (going from having a function name to just a comment defining it).
Thoughts on porting the rest of the tests in this file to this format?
I'm not sure which I prefer
There was a problem hiding this comment.
@djrtwo hmm, good question. I don't feel particularly strongly either way, but am kinda leaning to keeping them as separate tests.
The code duplication we could get rid up would probably be counter-balanced by the extra comments we would need to explain each test. I experimented by moving the all safety oracle tests to the parameterized format, and things got dense and unreadable pretty quickly.
This works super great for testing utils though - just don't think it's the best for the test language :) Let me know what you think.
|
readme should be updated; not sure what the exact |
|
@zramsay readme updated |
|
👍 works great, tests pass |
|
@djrtwo this looks great - should be good to merge! I removed the parametrized version of the testing_language stuff based on comments above. Happy to add back/move rest of tests to that format if we decide it's better. Let me know. I'm going to add an issue about the errors rather than adding it here so we can discuss further. |
|
Ah, let's add command line option for toggling reporting before merging this. |
…-casper into chore/migrate-to-pytest
add .circleci/config.yml
|
|
|
fixed. ready for review |
What was wrong
Issue #21
Issue #28
How was it fixed