Binary Protocol + Protocol Organization (step 1) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
changed the title
|
@djrtwo I'll check this out and merge it tonight! |
|
This would be _swell_!
…On Tuesday, October 31, 2017, Nate Rush ***@***.***> wrote:
@djrtwo <https://github.com/djrtwo> I'll check this out and merge it
tonight!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABXf-8jsHUtUETddY62xhGjjlb1770T_ks5sx895gaJpZM4QMKul>
.
|
|
Starting review now. |
naterush
reviewed
Nov 1, 2017
casper/binary/binary_view.py
Outdated
| class BinaryView(AbstractView): | ||
| """A view class that also keeps track of a last_finalized_block and children""" | ||
| def __init__(self, messages=None): | ||
| super().__init__() |
There was a problem hiding this comment.
Don't add messages here through super, but down in BlockchainView. We should pick one.
There was a problem hiding this comment.
I say do super.
You have to define add_messages in child, but the parent will always do the "if none, and add_message" call
| self.validator_set = validator_set | ||
| self.global_view = view_class() | ||
| self.global_view = protocol.View(set()) |
|
This looks good. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should get it merged in as is for now. Will allow Vlad to generate some binary gifs if he wants.
Stuff:
--protocol(defaults to blockchain) and must specify when making an experiment ("protocol")NOTE: This is pointed at master. This includes your binary stuff but I already merged in master to here and handled a bunch of conflicts. I recommend merging this into master when ready and closing the other Binary PR.