Skip to content

Commit

Permalink
Remove arbitrary condition
Browse files Browse the repository at this point in the history
  • Loading branch information
@dankrad
dankrad committed Sep 17, 2021
1 parent 5423bbc commit c18e8aa
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions specs/merge/p2p-interface.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ Alias `block = signed_beacon_block.message`, `execution_payload = block.body.exe
-- i.e. `execution_payload.timestamp == compute_time_at_slot(state, block.slot)`.
- _[REJECT]_ Gas used is less than the gas limit --
i.e. `execution_payload.gas_used <= execution_payload.gas_limit`.
- _[REJECT]_ The execution payload block hash is not equal to the parent hash --

This comment has been minimized.

Sign in to view

Copy link
@dankrad

dankrad Sep 17, 2021

Author Contributor

Don't get this specific condition -- it seems fairly random (since it doesn't verify that the hash is even correct).

Any specific DOS attack that this condition prevents?
i.e. `execution_payload.block_hash != execution_payload.parent_hash`.
- _[REJECT]_ The execution payload transaction list data is within expected size limits,
the data MUST NOT be larger than the SSZ list-limit,
and a client MAY be more strict.

This comment has been minimized.

Sign in to view

Copy link
@dankrad

dankrad Sep 17, 2021

Author Contributor

MAY be more strict feels super vague. I assume that means it may reject any block that fails to pass some other validity conditions including the state transition, but it reads as if a client could just reject any block.
Expand Down

0 comments on commit c18e8aa

Please sign in to comment.