Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document all intermediate values that are signed integers #1090

Closed
sorpaas opened this issue May 17, 2019 · 2 comments
Closed

Document all intermediate values that are signed integers #1090

sorpaas opened this issue May 17, 2019 · 2 comments

Comments

@sorpaas
Copy link

sorpaas commented May 17, 2019

Values, like (pivot - index) in get_shuffled_index, are required to be signed (in the plain form represented there). So it would be great to document all cases of them (as some clients have the assumptions that integers are unsigned).
@JustinDrake
Copy link
Collaborator

(pivot - index) in get_shuffled_index

Good catch! Fixed in #1092. Do you see other instances?

@djrtwo djrtwo closed this as completed in 05f9dc7 May 17, 2019
djrtwo added a commit that referenced this issue May 17, 2019
@djrtwo
Merge pull request #1092 from ethereum/JustinDrake-patch-10
7e9b00f 
Fix #1090
@sorpaas
Copy link
Author

sorpaas commented May 17, 2019

No I haven't found others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JustinDrake @sorpaas