Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify maximum revert period #577

Closed
JustinDrake opened this issue Feb 7, 2019 · 2 comments
Closed

Specify maximum revert period #577

JustinDrake opened this issue Feb 7, 2019 · 2 comments
Assignees
Labels
general:bug Something isn't working

Comments

@JustinDrake
Copy link
Collaborator

JustinDrake commented Feb 7, 2019

What is the desired behaviour if two beacon chain forks A and B do not advance justification for 4+ months, and then fork A (e.g. thanks to inactivity penalties) wins the race to justify first? We probably do not want fork B to honour the new justification in fork A.

@vbuterin
Copy link
Contributor

vbuterin commented Feb 7, 2019

I think clients should just refuse to revert further than some maximum revert period, though now that we're dynamically calculating that, it should be dynamically calculated....

I'd say one important first thing to do is to add the explicit criterion that a client does not revert finalized blocks.

@JustinDrake JustinDrake changed the title Enshrine weak subjectivity threshold in fork choice rule Specify maximum revert period Feb 7, 2019
@JustinDrake JustinDrake added the general:bug Something isn't working label Feb 13, 2019
@JustinDrake
Copy link
Collaborator Author

Closing in favour of #675.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants