Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two effective_balance bugs #1004

Merged
merged 2 commits into from
Apr 29, 2019
Merged

Fix two effective_balance bugs #1004

merged 2 commits into from
Apr 29, 2019

Conversation

JustinDrake
Copy link
Collaborator

  • Initialisation bug: initial effective_balance be not greater than MAX_EFFECTIVE_BALANCE
  • Hysteresis bug: do not prevent effective_balance to go from MAX_EFFECTIVE_BALANCE - 1 to MAX_EFFECTIVE_BALANCE

ralexstokes and others added 2 commits April 26, 2019 20:50
Fix attribute access; this field has been renamed in the latest version of the phase 0 spec.
* Initialisation bug: initial `effective_balance` be not greater than `MAX_EFFECTIVE_BALANCE`
* Hysteresis bug: do not prevent `effective_balance` to go from `MAX_EFFECTIVE_BALANCE - 1` to `MAX_EFFECTIVE_BALANCE`
@JustinDrake JustinDrake added the general:bug Something isn't working label Apr 26, 2019
@djrtwo djrtwo changed the base branch from dev to master April 26, 2019 14:59
@djrtwo
Copy link
Contributor

djrtwo commented Apr 26, 2019

Changed this to point to master. Would like to get minor bug fixes out as v0.6.1 shortly.
Still pending review. thanks!

@djrtwo djrtwo merged commit dc458bf into master Apr 29, 2019
@djrtwo djrtwo deleted the JustinDrake-patch-10 branch April 29, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants