Remove get_state_root from state transition doc #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `get_state_root` from the state transition function spec because it is not used by the state transition function.
hwwhww
approved these changes
May 1, 2019
JustinDrake
added
general:presentation
|
Generally agree except with the "Also note that get_state_root is slot-based which is inconsistent with its get_block_root counterpart" argument. We store state roots per slot in state so makes sense to give slot granular access :) |
…cs into JustinDrake-patch-11
djrtwo
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
get_state_rootfrom the state transition function spec because it is not used by the state transition function. (Unused code affects spec testability and conciseness. Also note thatget_state_rootis slot-based which is inconsistent with itsget_block_rootcounterpart.)The
get_state_roothelper is used by the test suite and is now defined there. If useful to validators beyond the test suite, it may make sense to defineget_state_rootin the validator doc.