Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate state_transition.py into state transition spec #1018
Incorporate state_transition.py into state transition spec #1018
Changes from 6 commits
8b316c6
591a2b4
5df79d7
2e63a9b
9b24d06
7980cf3
9f2cdd9
197a720
4c1073f
f371dae
50009ea
9eeca0c
c37157e
8da4b81
27c8e41
7bb85a6
a0a2aa9
5ba90d6
c60635d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say enable it in the spec, and hack it in the tests.
/cc @djrtwo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit torn here.
options:
verify_state_root
boolean inprocess_block
andstate_transition
and a note about in which context you would run it as True or False (receiving a block vs building a block)verify_block_state_root
live outside of the state transition function entirely and as a note on block validity below.I think I like (2) the best, but am open to debate.
*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion would be for the test bench to populate the
state_root
immediately prior to verification in case it is set toZERO_HASH
. That way we can keep the spec clean. Could that work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some sort of monkey patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes