Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter #1065

Merged
merged 5 commits into from
May 11, 2019
Merged

Add linter #1065

merged 5 commits into from
May 11, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented May 9, 2019

  • Fix add linter to CI #1062
  • max-line-length=120
  • Now it checks the whole eth2spec (flake8 --max-line-length=120 ./eth2spec).

@hwwhww hwwhww requested review from protolambda and djrtwo May 9, 2019 07:04
protolambda
protolambda approved these changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good 👍

@protolambda protolambda merged commit acf0789 into dev May 11, 2019
@protolambda protolambda deleted the linter branch May 11, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

@djrtwo djrtwo Awaiting requested review from djrtwo

Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add linter to CI
2 participants
@hwwhww @protolambda