Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix to how eth1 data is counted in validator guide #1108

Merged
merged 2 commits into from
May 28, 2019
Merged

minor fix to how eth1 data is counted in validator guide #1108

merged 2 commits into from
May 28, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented May 21, 2019

Fix minor issue in v-guide using an old method to count eth1 votes

@djrtwo
Copy link
Contributor Author

djrtwo commented May 27, 2019

Done @hwwhww, but the build is failing due to credit 😬

hwwhww
hwwhww approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think this PR is totally fine to be merged although the CI is blocking... 😓

@djrtwo djrtwo merged commit c2f0f7e into dev May 28, 2019
@djrtwo djrtwo deleted the eth1_error branch May 28, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djrtwo @hwwhww