Finish state tests intro #1114
Merged
Finish state tests intro #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocs for epoch sub-transition testing
djrtwo
reviewed
May 24, 2019
test_libs/pyspec/eth2spec/test/epoch_processing/test_process_crosslinks.py
Outdated
Show resolved
Hide resolved
test_libs/pyspec/eth2spec/test/epoch_processing/test_process_registry_updates.py
Outdated
Show resolved
Hide resolved
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
…rosslinks.py Co-Authored-By: Danny Ryan <dannyjryan@gmail.com>
hwwhww
approved these changes
May 24, 2019
|
|
||
|
|
||
| def create_suite(transition_name: str, config_name: str, get_cases: Callable[[], Iterable[gen_typing.TestCase]]) \ | ||
| -> Callable[[str], gen_typing.TestSuiteOutput]: |
There was a problem hiding this comment.
nitpick: IMO avoid \ here
def create_suite(
transition_name: str,
config_name: str,
get_cases: Callable[[],
Iterable[gen_typing.TestCase]]) -> Callable[[str], gen_typing.TestSuiteOutput]:There was a problem hiding this comment.
My IDE gives a PEP8 warning with that suggestion.
There was a problem hiding this comment.
And formatter adds 20 spaces of indentation to the last line of that suggestion, and then it's happy... I'd rather keep it as-is.
|
|
||
|
|
||
| def create_suite(operation_name: str, config_name: str, get_cases: Callable[[], Iterable[gen_typing.TestCase]]) \ | ||
| -> Callable[[str], gen_typing.TestSuiteOutput]: |
There was a problem hiding this comment.
ditto
def create_suite(
transition_name: str,
config_name: str,
get_cases: Callable[[],
Iterable[gen_typing.TestCase]]) -> Callable[[str], gen_typing.TestSuiteOutput]:There was a problem hiding this comment.
See above comment
test_libs/pyspec/eth2spec/test/epoch_processing/test_process_crosslinks.py
Outdated
Show resolved
Hide resolved
djrtwo
reviewed
May 24, 2019
test_libs/pyspec/eth2spec/test/epoch_processing/test_process_registry_updates.py
Show resolved
Hide resolved
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces:
TODO (draft):