-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify deposits #1122
Simplify deposits #1122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we merge this we should remove the index from the log in the deposit contract...
Maybe? The client still needs to hold a local tree of all deposits so the index might be slightly useful? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I fixed the failing deposit test, but circleci is currently broken.
Let's hold off merge until that's fixed
@djrtwo i guess this comes down to how strongly we want to have the |
Remove unnecessary index field from
Deposit
while retaining the requirement that deposits are processed in order.