Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify deposits #1122

Merged
merged 4 commits into from
May 30, 2019
Merged

Simplify deposits #1122

merged 4 commits into from
May 30, 2019

Conversation

JustinDrake
Copy link
Collaborator

@JustinDrake JustinDrake commented May 24, 2019

Remove unnecessary index field from Deposit while retaining the requirement that deposits are processed in order.

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we merge this we should remove the index from the log in the deposit contract...

specs/core/0_beacon-chain.md Show resolved Hide resolved
@JustinDrake JustinDrake mentioned this pull request May 27, 2019
9 tasks
@djrtwo
Copy link
Contributor

djrtwo commented May 27, 2019

if we merge this we should remove the index from the log in the deposit contract...

Maybe? The client still needs to hold a local tree of all deposits so the index might be slightly useful?

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I fixed the failing deposit test, but circleci is currently broken.
Let's hold off merge until that's fixed

@ralexstokes
Copy link
Member

Maybe? The client still needs to hold a local tree of all deposits so the index might be slightly useful?

@djrtwo i guess this comes down to how strongly we want to have the index be part of the protocol -- if we take it out, clients will likely still have the index locally, it just won't be required for the deposit contract

@djrtwo djrtwo merged commit 0fd29f7 into dev May 30, 2019
@djrtwo djrtwo deleted the JustinDrake-patch-13 branch May 30, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants