Sort attester slashing indices to avoid arbitrary ordering #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good solution. Have we checked if we are iterating over dicts/sets anywhere else where it could cause problems? |
dankrad
approved these changes
May 27, 2019
djrtwo
approved these changes
May 27, 2019
|
Nice catch! @dankrad I have a PR in the works that turns some of the things in the spec to |
|
Thanks :) If there's going to be a v0.6.2 release could it include this patch? |
|
Releasing it in v0.6.3! |
djrtwo
added a commit
that referenced
this pull request
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1125