Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PySpec SSZ Bytes instantiated from hex string #1551

Merged
merged 2 commits into from
Dec 30, 2019
Merged

Conversation

CarlBeek
Copy link
Contributor

This enables PySpec SSZ to instantiate Bytes from hex strings as input (both with and without leading 0x). This removes some hackiness in the form of special cases from the spec builder. Bytes objects can then be created directly from octal strings without being exposed to python's ugly byte formatting.

specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
specs/core/1_custody-game.md Outdated Show resolved Hide resolved
specs/core/1_shard-data-chains.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@protolambda protolambda merged commit d3c2dd0 into dev Dec 30, 2019
@djrtwo djrtwo deleted the carl_Bytes_hex branch December 31, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:SSZ Simple Serialize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants