Add libp2p-noise specification #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Libp2p has added a specification for the noise handshake. This PR references this specification for our mainnet configuration.
There are two interesting points here:
secp256k1peer identities as these keys are currently specified for ENR's in discv5 and allows us to the use the same identity for both discovery and the rest of the libp2p stack.XXhandshake and optionally theIKandXXfallback. I've explicitly mentioned this in the eth2.0 specs making it clear for eth2.0 implementers. The added handshakes provide an optimisation in some circumstances and clients can optionally add these in the future.As always, open to feedback/suggestions on this PR.