add eth2 key/value ENR to phase 0 p2p #1614
The actual PR is generic, so looks fine to me.
When doing status messages, which fork version should be sent (and which fork version is in the ENR), the one from the state or a client-maintained
From discussion earlier: how do we handle the pre-genesis case, where the root is not yet known? Default to
The PR looks good to me , 1) seems to be the simplest and makes the most sense to me.
This is a safe assumption, I do not know if there would ever be a situation where there is a network upgrade without updating the fork version.
For pre-genesis it would make sense to default with
either one is fine with me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.