Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version to v0.11.0 for coming release #1647

Merged
merged 1 commit into from
Mar 11, 2020
Merged

bump version to v0.11.0 for coming release #1647

merged 1 commit into from
Mar 11, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Mar 9, 2020

No description provided.

@djrtwo djrtwo requested a review from protolambda March 9, 2020 18:03
@djrtwo djrtwo mentioned this pull request Mar 9, 2020
Merged
protolambda
protolambda reviewed Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagined we would add this change on top of the release PR as final bit. And generally we should keep dev tagged with some dev version.

@djrtwo
Copy link
Contributor Author

djrtwo commented Mar 10, 2020 •
edited
Loading

So actually inside of master after the release is merged?
then backport to some dev versioning?

Or should we change to v0.11.0-dev0 in dev then strip the -dev0 once released to master

@protolambda
Copy link
Collaborator

I thought about it more, and I think that it doesn't actually matter much for dev, so updating ahead of release sounds ok. You would need to pull a specific branch anyway to get something else than the master version, so let's only use dev or other add-ons in the version if we make temporary builds for special cases.

@djrtwo djrtwo merged commit 8eae0f0 into dev Mar 11, 2020
@djrtwo djrtwo deleted the bump-version branch March 11, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djrtwo @protolambda