Put back in a requirement to store recent signed blocks #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved when SignedBeaconBlock was introduced (prior to that the signature was in BeaconBlock, which was recorded in Store).
protolambda
reviewed
Mar 10, 2020
Co-Authored-By: Diederik Loerakker <proto@protolambda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In spec 0.9.2 and earlier, the signature was in BeaconBlock, which was recorded in Store, so clients would generally have the blocks available to service requests (i.e. pass the "if they have it" criteria).
However since SignedBeaconBlock was introduced there has been no explicit storage of signed blocks received.
While the specification says "MUST support requesting" it is qualified by "respond .. if they have it".
This change removes any confusion by putting back in an explicit requirement to store blocks (although the mechanism is not specified, i.e. they are no longer necessarily in Store).
Further information is in issue #1641