Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic SSZ tests, update remerkleable with small bugfix #1657

Merged
merged 1 commit into from Mar 11, 2020

Conversation

protolambda
Copy link
Collaborator

  • Update remerkleable to include minor bugfix, setting/getting on medium/large bitvectors was incorrect, but didn't seem to affect the spec directly.
  • Fix generic SSZ typing usage
  • Workaround to create empty vector output, remerkleable doesn't allow this invalid test case.

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks for quick fix on this

@djrtwo djrtwo merged commit 42499a0 into dev Mar 11, 2020
@djrtwo djrtwo deleted the fix-ssz-generic-tests branch March 11, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants