Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peer discovery and topics prior to genesis #1708

Merged
merged 1 commit into from Apr 6, 2020
Merged

peer discovery and topics prior to genesis #1708

merged 1 commit into from Apr 6, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Apr 6, 2020

Addresses #1700 by noting that peer discovery and gossip topic subscriptions should not happen prior to knowing the genesis state. After genesis state is known, clients have at least MIN_GENESIS_DELAY to find peers and form connections

@djrtwo djrtwo requested a review from protolambda April 6, 2020 15:59
protolambda
protolambda approved these changes Apr 6, 2020
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if there is still sufficient time to peer later then waiting for known genesis state is fine.

@protolambda protolambda merged commit 71b0640 into dev Apr 6, 2020
@protolambda protolambda deleted the peers-before-genesis branch April 6, 2020 16:32
@hwwhww hwwhww mentioned this pull request Apr 20, 2020
Closed
@ColinSchwarz ColinSchwarz mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djrtwo @protolambda