-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sanity unit test for validator guide + update validator guide #1745
Merged
+410
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
reviewed
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! finally, we won't introduce silly errors when updating v-guide and this should help in the phase 1 v-guide dev too :)
tests/core/pyspec/eth2spec/test/validator/test_validator_unittest.py
Outdated
Show resolved
Hide resolved
1. Avoid negative computation in `is_candidate_block` 2. Fix `get_block_signature`: avoid extra casting; it's simpler to use BeaconBlock instead of BeaconHeader
1. "Becoming a validator" 2. "Validator assignments" 3. "Beacon chain responsibilities: Block proposal"
1. "Beacon chain responsibilities: Attesting" 2. "Beacon chain responsibilities: Attestation aggregation"
d206282
to
a82b64f
Compare
Fix get_eth1_vote test cases
…eth1 votes consensus
bac1ec7
to
2dbc333
Compare
@djrtwo thanks for the review! Changelog
|
djrtwo
approved these changes
Apr 27, 2020
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
93%
to99%
is_candidate_block
get_block_signature
: avoid extra casting; it's simpler to useBeaconBlock
instead ofBeaconHeader
.compute_new_state_root
a pure function.minimal.config
: IncreaseEPOCHS_PER_ETH1_VOTING_PERIOD
from2
to4
for testing eth1 votes consensus vote