Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gossipsub v1.1 and extended validators #1796

Merged
merged 1 commit into from
May 11, 2020
Merged

Gossipsub v1.1 and extended validators #1796

merged 1 commit into from
May 11, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented May 8, 2020

address #1792

  • Make explicit note of gossipsub v1.1 as a requirement
  • Add extended validators enums to the gossip conditions

@djrtwo djrtwo requested a review from protolambda May 8, 2020 18:02
@djrtwo djrtwo changed the base branch from dev to v012x May 8, 2020 18:03
protolambda
protolambda approved these changes May 8, 2020
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, later we may want to present Gossipsub v1.1 more as the expected default; changing Clients MUST reject (fail validation) messages c... to be more explicit a REJECT and introduces ... naturally changes to something more passive.

@hwwhww hwwhww added this to the v0.12.0 milestone May 9, 2020
@djrtwo djrtwo merged commit 8fe43e1 into v012x May 11, 2020
@djrtwo djrtwo deleted the gossipsub-v1.1 branch May 11, 2020 14:11
@Nashatyrev
Copy link
Member

Shouldn't the protocol string be upgraded to /meshsub/1.1.0?

@protolambda
Copy link
Collaborator

@Nashatyrev Good catch, thank you. Yes I think so, although the new Gossipsub should be compatible. @djrtwo what do you think?

@djrtwo djrtwo mentioned this pull request May 20, 2020
Closed
@terencechain terencechain mentioned this pull request May 20, 2020
Closed
25 tasks
@paulhauner paulhauner mentioned this pull request May 21, 2020
Closed
22 tasks
@ColinSchwarz ColinSchwarz mentioned this pull request May 25, 2020
Closed
@nisdas nisdas mentioned this pull request May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
scope:libp2p
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@djrtwo @Nashatyrev @protolambda @hwwhww