Fix bitfield_bytes type error
#1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
reviewed
May 13, 2020
| * `mix_in_length(merkleize(pack(value), limit=chunk_count(type)), len(value))` if `value` is a list of basic objects. | ||
| * `mix_in_length(merkleize(bitfield_bytes(value), limit=chunk_count(type)), len(value))` if `value` is a bitlist. | ||
| * `mix_in_length(merkleize(pack_bits(value), limit=chunk_count(type)), len(value))` if `value` is a bitlist. |
There was a problem hiding this comment.
mix_in_length(merkleize(pack(bitfield_bytes(value), limit=chunk_count(type)), len(value)) would also work. But being explicit here is not a bad idea.
|
Also confirm that the spec was misleading here, good catch and fix. Thanks. |
djrtwo
approved these changes
May 18, 2020
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Address #1787.
How did I fix it
Rename
bitfield_bytestopack_bitsand make this function returnBYTES_PER_CHUNK-byte chunks.p.s. it seems the spec was misleading but the implementations are all good? /cc @protolambda to confirm.