remove faulty de-duplication condition for seen aggregates #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
approved these changes
Mar 14, 2021
5 tasks
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Feb 25, 2022
ethereum/consensus-specs#2225 removed an ignore rule that would filter out duplicate aggregates from gossip publishing - however, this causes increased bandwidth and CPU usage as discussed in ethereum/consensus-specs#2183 - the intent is to revert the removal and reinstate the rule. This PR implements ignore filtering which cuts down on CPU usage (fewer aggregates to validate) and bandwidth usage (less fanout of duplicates) - as #2225 points out, this may lead to a small increase in IHAVE messages.
arnetheduck
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Feb 25, 2022
ethereum/consensus-specs#2225 removed an ignore rule that would filter out duplicate aggregates from gossip publishing - however, this causes increased bandwidth and CPU usage as discussed in ethereum/consensus-specs#2183 - the intent is to revert the removal and reinstate the rule. This PR implements ignore filtering which cuts down on CPU usage (fewer aggregates to validate) and bandwidth usage (less fanout of duplicates) - as #2225 points out, this may lead to a small increase in IHAVE messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2183
The alternative would be to have a more exotic message-id that is only a function of
aggregate_and_proof.aggregate.I suggest we observe mainnet's aggregation data and make a call.