Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify sync committee logic and parameters to reduce variance #2453

Merged
merged 8 commits into from Jun 4, 2021
Merged

Modify sync committee logic and parameters to reduce variance #2453

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a89ecce
Modify sync committee logic and parameters to reduce variance
vbuterin May 27, 2021
3cd842a
Update specs/altair/beacon-chain.md
ralexstokes May 27, 2021
b0500c3
Update specs/altair/beacon-chain.md
ralexstokes May 27, 2021
b298d4d
Update mainnet preset file
hwwhww Jun 1, 2021
b8d426b
Align Sync Committee Tests to Specs
potuz May 31, 2021
c115fa9
make it pass the linter
potuz May 31, 2021
67809e7
Fix tests
hwwhww Jun 1, 2021
693b228
Merge pull request #2465 from ethereum/sync-committee-penalty-tests
djrtwo Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 11 additions & 9 deletions specs/altair/beacon-chain.md
View file
Open in desktop
Expand Up @@ -86,10 +86,10 @@ Altair is the first beacon chain hard fork. Its main features are:

| Name | Value |
| - | - |
| `TIMELY_SOURCE_WEIGHT` | `uint64(12)` |
| `TIMELY_TARGET_WEIGHT` | `uint64(24)` |
| `TIMELY_HEAD_WEIGHT` | `uint64(12)` |
| `SYNC_REWARD_WEIGHT` | `uint64(8)` |
| `TIMELY_SOURCE_WEIGHT` | `uint64(14)` |
| `TIMELY_TARGET_WEIGHT` | `uint64(26)` |
| `TIMELY_HEAD_WEIGHT` | `uint64(14)` |
| `SYNC_REWARD_WEIGHT` | `uint64(2)` |
| `PROPOSER_WEIGHT` | `uint64(8)` |
| `WEIGHT_DENOMINATOR` | `uint64(64)` |

Expand Down Expand Up @@ -129,7 +129,7 @@ This patch updates a few configuration values to move penalty parameters closer
| Name | Value | Unit | Duration |
| - | - | - | - |
| `SYNC_COMMITTEE_SIZE` | `uint64(2**9)` (= 512) | Validators | |
| `EPOCHS_PER_SYNC_COMMITTEE_PERIOD` | `uint64(2**9)` (= 512) | epochs | ~54 hours |
| `EPOCHS_PER_SYNC_COMMITTEE_PERIOD` | `uint64(2**8)` (= 256) | epochs | ~27 hours |

## Configuration

Expand Down Expand Up @@ -579,10 +579,12 @@ def process_sync_committee(state: BeaconState, aggregate: SyncAggregate) -> None
# Apply participant and proposer rewards
all_pubkeys = [v.pubkey for v in state.validators]
committee_indices = [ValidatorIndex(all_pubkeys.index(pubkey)) for pubkey in state.current_sync_committee.pubkeys]
participant_indices = [index for index, bit in zip(committee_indices, aggregate.sync_committee_bits) if bit]
for participant_index in participant_indices:
increase_balance(state, participant_index, participant_reward)
increase_balance(state, get_beacon_proposer_index(state), proposer_reward)
for index, participation_bit in zip(committee_indices, aggregate.sync_committee_bits):
ralexstokes marked this conversation as resolved.
Show resolved Hide resolved
if participant_bit:
ralexstokes marked this conversation as resolved.
Show resolved Hide resolved
increase_balance(state, participant_index, participant_reward)
increase_balance(state, get_beacon_proposer_index(state), proposer_reward)
else:
decrease_balance(state, participant_index, participant_reward)
```

### Epoch processing
Expand Down