Default to "zero" Eth1Data instead of current state #2501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
commented
Jul 1, 2021
| @@ -1732,8 +1732,9 @@ def process_randao(state: BeaconState, body: BeaconBlockBody) -> None: | |||
| ```python | |||
| def process_eth1_data(state: BeaconState, body: BeaconBlockBody) -> None: | |||
| state.eth1_data_votes.append(body.eth1_data) | |||
| if state.eth1_data_votes.count(body.eth1_data) * 2 > EPOCHS_PER_ETH1_VOTING_PERIOD * SLOTS_PER_EPOCH: | |||
| state.eth1_data = body.eth1_data | |||
| if body.eth1_data.block_hash != Bytes32(): | |||
There was a problem hiding this comment.
Regardless of the change to default volte, should we have a check in here that the deposit count can't go backwards? It can only happen if enough validators don't follow the honest validator spec but would definitely be a very odd case to allow.
|
Also worth noting that this would have to be rolled out as a soft fork - first deploy the state transition change, then change the default vote. Seems safe but is perhaps a reason to just use a random vote instead and deal with not being able to distinguish default votes from unknown blocks. |
|
At this point I think we can just give up on ever actually making this change. Eth1Data is working fine and the next time we change it should be to get rid of it entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2227 by changing the default vote to be zeroed out - zero block hash, deposit root and zero deposits. The state transition is updated to explicitly disallow the zero vote from becoming the current
Eth1Datain the spec.The zero vote is automatically ignored by
get_eth1_votebecause it won't be in the set of known blocks so doesn't lead validators to following a vote which doesn't progress the chain like defaulting to the currentstate.eth1_datadoes.The alternative approach would be for validators to vote for a random block hash which has the advantage of not needing to update the state transition rules as it's exceedingly unlikely 50% of validators will choose the same random data, but the downside of making it harder to identify default votes. Differentiating default votes from votes for unknown blocks is particularly useful when evaluating whether a beacon node is tracking the eth1 chain correctly.
Note: Python likely needs some tweaking but hopefully gets the idea across.