Add sync committee tests with exited and withdrawable members #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
reviewed
Sep 9, 2021
There was a problem hiding this comment.
Test looks good. I recommend reducing the copy paste with a runner function. Or at least a function in the middle that can be called to prepare an exited and/or withdrawable validator
You also could remove a lot of the logic by manually manipulating exit_epoch and withdrawable_epoch. that said, your call
...e/pyspec/eth2spec/test/altair/block_processing/sync_aggregate/test_process_sync_aggregate.py
Outdated
Show resolved
Hide resolved
djrtwo
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for members of the current sync committee to be in the exited or withdrawable validator lifecycle states.
This PR adds (spec) tests to ensure clients can handle these cases.