Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yield the pre state for this test type before making blocks #2672

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Yield the pre state for this test type before making blocks #2672

merged 1 commit into from
Oct 15, 2021

Conversation

ralexstokes
Copy link
Member

A few tests in v1.1.3 were broken due to a bug in the test generation code that did not yield the pre state early enough. This PR fixes it.

hwwhww
hwwhww approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the result slot number & mainnet tests locally. I like this approach more!

@hwwhww hwwhww mentioned this pull request Oct 15, 2021
Closed
@ralexstokes ralexstokes merged commit d0379cf into ethereum:dev Oct 15, 2021
@ralexstokes ralexstokes deleted the fix-altair-transition-tests branch October 15, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralexstokes @hwwhww