Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename coinbase to fee_recipient #2728

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Rename coinbase to fee_recipient #2728

merged 1 commit into from
Nov 18, 2021

Conversation

mkalinin
Copy link
Collaborator

@mkalinin mkalinin commented Nov 18, 2021 •
edited by djrtwo
Loading

Relates to ethereum/execution-apis#130

Renames:

  • coinbase to fee_recipient
  • fee_recipient to suggested_fee_recipient

cc @MicahZoltu

Note: Due to how SSZ serialization and hashing works, this is non-substantive and instead only cosmetic

@dapplion dapplion mentioned this pull request Nov 18, 2021
Closed
24 tasks
@terencechain terencechain mentioned this pull request Nov 18, 2021
Merged
hwwhww
hwwhww approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@hwwhww hwwhww added the Bellatrix CL+EL Merge label Nov 18, 2021
@djrtwo djrtwo merged commit 140f30d into ethereum:dev Nov 18, 2021
@realbigsean realbigsean mentioned this pull request Dec 2, 2021
Closed
@tbenr tbenr mentioned this pull request Dec 3, 2021
Closed
4 tasks
@alrevuelta alrevuelta mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicahZoltu MicahZoltu MicahZoltu approved these changes

@djrtwo djrtwo djrtwo approved these changes

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
Bellatrix CL+EL Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkalinin @MicahZoltu @djrtwo @hwwhww