Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spec typo and add test_prepare_execution_payload unit tests #2737

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Fix spec typo and add test_prepare_execution_payload unit tests #2737

merged 1 commit into from
Nov 23, 2021

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Nov 23, 2021

  1. Fix typo: get_current_epoch(state.slot) -> get_current_epoch(state)
  2. Add test_prepare_execution_payload unit tests for testing different condition combinations.

djrtwo
djrtwo approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@djrtwo djrtwo merged commit 32e8ca2 into dev Nov 23, 2021
@djrtwo djrtwo deleted the test_prepare_execution_payload branch November 23, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

@ralexstokes ralexstokes Awaiting requested review from ralexstokes

Assignees
No one assigned
Labels
scope:CI/tests/pyspec scope:v-guide Validator guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwwhww @djrtwo