Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set RNG seed in test_get_head.py #2776

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Set RNG seed in test_get_head.py #2776

merged 1 commit into from
Dec 23, 2021

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Dec 23, 2021

Issue

The RNG seed was unset such that the test vector result was not determined.

How did I fix it

Set a seed!

ralexstokes
ralexstokes approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! fixing the rng looks good....

i'm suspicious we need to go thru the hex conversion when making the random graffiti but that's out of scope for this PR so i'll just leave it for now

@ralexstokes ralexstokes merged commit 2f50057 into dev Dec 23, 2021
@ralexstokes ralexstokes deleted the test_proposer_boost_correct_head-rng branch December 23, 2021 16:47
@hwwhww hwwhww mentioned this pull request Dec 23, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwwhww @ralexstokes