Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receipt_root -> receipts_root #2808

Merged
merged 2 commits into from
Jan 20, 2022
Merged

receipt_root -> receipts_root #2808

merged 2 commits into from
Jan 20, 2022

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jan 17, 2022

Minor renaming for upcoming bellatrix spec release.

This was discussed and generally agreed upon on a public call. Due to the need to make a release patching the semantics of executePayload and forkchoiceUpdated, we are getting this in there as well

Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

specs/bellatrix/beacon-chain.md Outdated Show resolved Hide resolved
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@djrtwo djrtwo merged commit 2232d76 into dev Jan 20, 2022
@djrtwo djrtwo deleted the receipts-root branch January 20, 2022 15:38
Copy link

@lokera666 lokera666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants