Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore subset aggregates #2847

Merged
merged 3 commits into from
May 17, 2022
Merged

Ignore subset aggregates #2847

merged 3 commits into from
May 17, 2022

Commits on Mar 3, 2022

  1. Ignore subset aggregates

    When aggregates are propagated through the network, it is often the case
    that a better aggregate has already been seen - in particular, this
    happens when an aggregator has not been able to include itself in the
    mesh and therefore publishes an aggregate with only its own
    attestations.
    
    This new ignore rule allows dropping all aggregates that are
    (non-strict) subsets of aggregates that have already been seen on the
    network. In particular, it does not mandate dropping aggregates where a
    union of previous aggregates would cause it to become a subset).
    
    The logic for allowing this is based on the premise that any aggregate
    that has already been seen by a peer will also have been seen by its
    neighbours - a subset aggregate (strict or not) brings no new value to
    the aggregation algorithm, except in the extreme edge case where you
    could combine several such sparse aggregates into a single, more dense
    "combined" aggregate and thus use less block space.
    
    Further, as a small benefit, computing the `hash_tree_root` of the full
    aggregate is generally not done -however, `hash_tree_root(data)` is
    already done for other purposes as this is used as index in the beacon
    API.
    arnetheduck committed Mar 3, 2022
    Configuration menu
    Copy the full SHA
    a0755c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Configuration menu
    Copy the full SHA
    d5f4c46 View commit details
    Browse the repository at this point in the history
  2. typo

    arnetheduck committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    530c87e View commit details
    Browse the repository at this point in the history