Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow LightClientUpdate with genesis finality #2924

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Allow LightClientUpdate with genesis finality #2924

merged 3 commits into from
Jun 29, 2022

Commits on Jun 27, 2022

  1. Allow LightClientUpdate with genesis finality 

    When `state.finalized_checkpoint` references the genesis slot, it points
to an empty `root`, instead of the actual genesis block hash. This patch
updates the `LightClientUpdate` logic to allow including finality proofs
for genesis `finalized_checkpoint.root`, better supporting non-mainnet.
When including such a finality proof, the proof is for the empty `root`,
but `finalized_header` is kept zeroed out to signify this edge case.
    @etan-status
    etan-status committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    c10daf1 View commit details
    Browse the repository at this point in the history

  2. Switch condition order for readability 

    Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
    @etan-status @hwwhww
    etan-status and hwwhww committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    99e3032 View commit details
    Browse the repository at this point in the history

  3. Update finality update documentation

    @etan-status
    etan-status committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    65cfede View commit details
    Browse the repository at this point in the history