Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP4844: various fixes #3019

Merged
merged 3 commits into from
Sep 30, 2022
Merged

EIP4844: various fixes #3019

merged 3 commits into from
Sep 30, 2022

Conversation

terencechain
Copy link
Contributor

  • Add unit epoch to MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS
  • The current backfill blob validation is incorrect. It looks like it was copy-pasted from backfill block validation. I removed it. It might be worth considering what backfill validation we want for the blob. To validate the signature, we need to change BlobsSidecarsByRange to SignedBlobsSidecarsByRange. It may be worth checking that blobs are canonical by cross-referencing with the local fork choice view
  • Validator broadcasts signed_beacon_block, not beacon_block

@terencechain @dapplion
Update specs/eip4844/p2p-interface.md
779e6e7 
Co-authored-by: Lion - dapplion <35266934+dapplion@users.noreply.github.com>
@hwwhww hwwhww added the Deneb was called: eip-4844 label Sep 30, 2022
@djrtwo djrtwo merged commit 6b9e65f into ethereum:dev Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion left review comments

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
Deneb was called: eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@terencechain @djrtwo @dapplion @hwwhww