Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some type annotations for blobs #3021

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fix some type annotations for blobs #3021

merged 1 commit into from
Oct 5, 2022

Conversation

xrchz
Copy link
Contributor

@xrchz xrchz commented Oct 1, 2022

blobs should not be Sequence[BLSFieldElement], it should be Sequence[Sequence[BLSFieldElement]]. But we can be more specific and use Sequence[Blob].

blobs should not be Sequence[BLSFieldElement], it should be
Sequence[Sequence[BLSFieldElement]]. But we can be more specific and use
Sequence[Blob].
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 7b1b937 into ethereum:dev Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants