Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capella test vectors #3040

Merged
merged 5 commits into from
Oct 22, 2022
Merged

Capella test vectors #3040

merged 5 commits into from
Oct 22, 2022

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Oct 15, 2022 •
edited

  • Fix capella/fork.md: since ExecutionPayloadHeader is changed in Capella, we need to implement new BeaconState.latest_execution_payload_header object.
  • Add Capella to test vector generators
  • Also add eip4844/ssz_static together... other test generators are WIP.

I've generated it successfully locally.

@ethereum ethereum deleted a comment Oct 15, 2022
djrtwo
djrtwo reviewed Oct 16, 2022
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! quick note about getting BLSChange operations inside of random tests. otherwise, good to go

tests/core/pyspec/eth2spec/test/utils/randomized_block_tests.py Show resolved Hide resolved
tests/generators/fork_choice/main.py Outdated Show resolved Hide resolved
tests/generators/genesis/main.py Outdated Show resolved Hide resolved
@ethereum ethereum deleted a comment from Where-2 Oct 16, 2022
@hwwhww hwwhww merged commit 9844ea1 into dev Oct 22, 2022
@hwwhww hwwhww deleted the capella-test-vectors branch October 22, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo left review comments

Assignees
No one assigned
Labels
Capella scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwwhww @djrtwo