Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass blocks to LC data creation functions #3070

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

etan-status
Copy link
Contributor

Future light client protocol extensions may include data from the block in addition to data from the state, e.g., ExecutionPayloadHeader. To prepare for this, also pass the block to the corresponding functions. In practice, blocks access is easier than historic state access, meaning there are no practical limitations due to this change.

Future light client protocol extensions may include data from the block
in addition to data from the state, e.g., `ExecutionPayloadHeader`.
To prepare for this, also pass the block to the corresponding functions.
In practice, blocks access is easier than historic state access, meaning
there are no practical limitations due to this change.
Copy link
Contributor

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, causes no change in output now, just sets the groundwork for adding an execution header later.

@etan-status
Copy link
Contributor Author

etan-status commented Nov 7, 2022

Yep. Preview of the full change: etan-status@lc-eph
Splitting it up into multiple logical pieces so that it is actually reviewable

Also related:
– 3066 (prep for new tests that are based on BeaconBlockBody)
– 3070 (prep for executionpayload in LC headers)
– 3072 (prep for more maintainable tests, currently capella/eip4844 work has not updated LC test helpers)
– 3078 (RLP hashes in ExecutionPayloadHeader, so that it is possible to drive LES)

Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@etan-status
Copy link
Contributor Author

Anything still blocking this?

@hwwhww hwwhww merged commit 2a7083d into ethereum:dev Dec 6, 2022
@etan-status etan-status deleted the lc-blockfuncs branch December 6, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants