-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slot checks in light client p2p spec #3086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, otherwise there is a mild DoS vector where I just keep spamming the current update to add load to the gossip net
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me, CC: @etan-status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes, that was the intention (slots must strictly monotonically increase in gossip), and is also how it is implemented in Nimbus. The new wording is clearer as well.
I think the p2p spec for light client updates should require the received update to be newer than previously forwarded updates. In other words, the condition should be corrected to:
However I think it's somewhat clearer to state the condition without a negation, as in: