Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initialization of VERSIONED_HASH_VERSION_KZG #3123

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Fix initialization of VERSIONED_HASH_VERSION_KZG #3123

merged 1 commit into from
Nov 22, 2022

Conversation

zilm13
Copy link
Contributor

@zilm13 zilm13 commented Nov 22, 2022 •
edited
Loading

See protolambda/remerkleable#15
In current dev inits with 00
btw, checked the whole spec and have not found another similar bad BytesXX initializations

hwwhww
hwwhww approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👍 😱

Note: EIP-4844 test vectors would need this fix. /cc @djrtwo

@hwwhww hwwhww merged commit 2d99f1b into ethereum:dev Nov 22, 2022
@zilm13 zilm13 deleted the fix/kzg-constant branch November 22, 2022 10:17
@hwwhww hwwhww added the Deneb was called: eip-4844 label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
Deneb was called: eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zilm13 @hwwhww