Remove fork-choice weight of slashed validators #3173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing active_indices to unslashed_and_active indices. Presently, we give fork-choice weight to slashed but active validators, unless they are included in equivocating_indices, and also say: "`on_attester_slashing` should be called while syncing and a client MUST maintain the equivocation set of `AttesterSlashing`s from at least the latest finalized checkpoint." Some validator might have been slashed prior to the latest finalized checkpoint, but not yet exited, due to the exit queue being full, in which case some validators might count their fork-choice weight and others might not. If instead we use unslashed_and_active_indices, no one would count their fork-choice weight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing active_indices to unslashed_and_active indices. Presently, we give fork-choice weight to slashed but active validators, unless they are included in equivocating_indices, and also say: "
on_attester_slashingshould be called while syncing and a client MUST maintain the equivocation set ofAttesterSlashings from at least the latest finalized checkpoint." Some validator might have been slashed prior to the latest finalized checkpoint, but not yet exited, due to the exit queue being full, in which case some validators might count their fork-choice weight and others might not. If instead we use unslashed_and_active_indices, no one would count their fork-choice weight.