Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP4844: Clarify ratelimit behavior for sidecar with zero blobs #3174

Merged
merged 7 commits into from
Jan 12, 2023
Merged

EIP4844: Clarify ratelimit behavior for sidecar with zero blobs #3174

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5a75704
Clarify behavior for empty blobs sidecar
terencechain Dec 23, 2022
42121ad
Clarify what empty means
terencechain Dec 23, 2022
518c49b
Update specs/eip4844/p2p-interface.md
terencechain Dec 23, 2022
491bb1d
Clean ups
terencechain Dec 23, 2022
7204b5c
Merge branch 'clarify-empty-blob-sidecar' of github.com:terencechain/…
terencechain Dec 23, 2022
96a5536
Add rate limit suggestion
terencechain Jan 10, 2023
8d841c8
minor copy edit
djrtwo Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions specs/eip4844/p2p-interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,9 @@ The following blobs sidecars, where they exist, MUST be sent in consecutive orde

Clients MAY limit the number of blobs sidecars in the response.

An empty `BlobSidecar` is one that does not contain any blobs, but contains non-zero `beacon_block_root`, `beacon_block_slot` and a valid `kzg_aggregated_proof`.
Clients MAY NOT want to consider empty `BlobSidecar`s in rate limiting logic.

The response MUST contain no more than `count` blobs sidecars.

Clients MUST respond with blobs sidecars from their view of the current fork choice
Expand Down