Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move experimental features to specs/_features folder #3248

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Move experimental features to specs/_features folder #3248

merged 2 commits into from
Feb 16, 2023

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Feb 14, 2023

  • Address Move the in-development features to specs/features folder #3240, but instead spec/features, I go with spec/_features since I feel it is more readable and easier to find in the specs folder.
  • Fix some links. Although these docs are pretty outdated now and some references should be linked to the latest mainnet version.

@hwwhww hwwhww added the general:proofread spelling, grammar, accuracy label Feb 14, 2023
@hwwhww hwwhww requested a review from djrtwo February 14, 2023 16:39
djrtwo
djrtwo approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

This make sense to me and is an important component of managing complexity as/if we adopt the EIP/feature process (before compiling down into fork/upgrade specs)

@hwwhww hwwhww merged commit ab11a01 into dev Feb 16, 2023
@hwwhww hwwhww deleted the mv-features branch February 16, 2023 09:03
@hwwhww hwwhww mentioned this pull request Feb 16, 2023
Merged
@hwwhww hwwhww mentioned this pull request May 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
general:proofread spelling, grammar, accuracy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwwhww @djrtwo