Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deneb : Change description for blob #3291

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

kevaundray
Copy link
Contributor

The current description of blob contains the word blob which seemed kida of recursive.

I changed it to note that its just a seuence of bytes which may uniquely encode the evaluations of a polynomial.

may: because the blob may be non-canonical. In this case when we convert it to a polynomial, it will fail.

@dankrad
Copy link
Contributor

dankrad commented Mar 14, 2023

I'm not sure this is a problem. This is not the definition of what a "blob" is, but rather what the Blob data type is. But I think it should be "data blob" rather than "blob data".

In you new description, I am a little confused by "may uniquely encode the evaluations of a polynomial" -- why may? It does, right?

@kevaundray
Copy link
Contributor Author

I'm not sure this is a problem. This is not the definition of what a "blob" is, but rather what the Blob data type is. But I think it should be "data blob" rather than "blob data".

In you new description, I am a little confused by "may uniquely encode the evaluations of a polynomial" -- why may? It does, right?

Ah fair point re description of Blob data type and not definition. I can change it to data blob.

The may part was to convey that blobs do not need to be canonical -- two blobs could map to the same polynomial if you don't correctly validate the blob

@dankrad
Copy link
Contributor

dankrad commented Mar 15, 2023

The may part was to convey that blobs do not need to be canonical -- two blobs could map to the same polynomial if you don't correctly validate the blob

Actually we require them to be canonical in order to be valid Blobs.

@kevaundray
Copy link
Contributor Author

The may part was to convey that blobs do not need to be canonical -- two blobs could map to the same polynomial if you don't correctly validate the blob

Actually we require them to be canonical in order to be valid Blobs.

Yep, though blobs are not valid/canonical by definition -- if this were the case we could skip the canonical/validation checks

@djrtwo djrtwo merged commit 41f4472 into ethereum:dev Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants