Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version.txt to 1.3.0-rc.5 #3303

Merged
merged 1 commit into from
Mar 20, 2023
Merged

bump version.txt to 1.3.0-rc.5 #3303

merged 1 commit into from
Mar 20, 2023

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Mar 20, 2023

No description provided.

@hwwhww hwwhww mentioned this pull request Mar 20, 2023
Merged
2 tasks
@hwwhww hwwhww changed the title bump version.txt to 1.3.0 bump version.txt to 1.3.0-rc.5 Mar 20, 2023
@hwwhww
Copy link
Contributor Author

hwwhww commented Mar 20, 2023

Per @djrtwo's suggestion, I changed it to 1.3.0-rc.5.

Last time, we did an RC until right after mainnet fork. With the idea that up until it's activated in mainnet, there is always a chance that there could be a breaking change. After that, it would always be a new version to change anything
That's how EL specs work too
I'm not fundamentally opposed to thw strategy of doing a non RC now but wanted to provide history and context

@hwwhww hwwhww merged commit 0b76c83 into dev Mar 20, 2023
@hwwhww hwwhww deleted the bump-version branch March 20, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

@ralexstokes ralexstokes Awaiting requested review from ralexstokes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwwhww @djrtwo