Deneb refactoring and new tests #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asn-d6
reviewed
May 2, 2023
djrtwo
reviewed
May 3, 2023
| @@ -173,6 +173,8 @@ def tx_peek_blob_versioned_hashes(opaque_tx: Transaction) -> Sequence[VersionedH | |||
| message_offset | |||
| + uint32.decode_bytes(opaque_tx[(message_offset + 188):(message_offset + 192)]) | |||
| ) | |||
| # `VersionedHash` is a 32-byte object | |||
| assert (len(opaque_tx) - blob_versioned_hashes_offset) % 32 == 0 | |||
There was a problem hiding this comment.
Should this be a length check instead of a mod check?
There was a problem hiding this comment.
It's the total length of blob_versioned_hashes: List[VersionedHash, MAX_VERSIONED_HASHES_LIST_SIZE] so it is multiples of 32.
| @@ -248,8 +250,7 @@ def process_execution_payload(state: BeaconState, payload: ExecutionPayload, exe | |||
| #### Blob KZG commitments | |||
|
|
|||
| ```python | |||
| def process_blob_kzg_commitments(state: BeaconState, body: BeaconBlockBody) -> None: | |||
| # pylint: disable=unused-argument | |||
| def process_blob_kzg_commitments(body: BeaconBlockBody) -> None: | |||
There was a problem hiding this comment.
I guess parallelism to other process_* functions is the argument to keep it. But I do think that argument is weak
djrtwo
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert (len(opaque_tx) - blob_versioned_hashes_offset) % 32 == 0check intx_peek_blob_versioned_hashesfor better error detectionprocess_blob_kzg_commitmentsfunction signature by removingstatedeneb/sanity/test_blocks.pytest cases.