Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process_inactivity_updates test cases #3348

Merged
merged 1 commit into from
May 8, 2023
Merged

Fix process_inactivity_updates test cases #3348

merged 1 commit into from
May 8, 2023

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented May 6, 2023

Issue

These two tests didn't use yield from so they were never executed...!

How did I fix it

  • Add yield from
  • test_randomized_state_leaking failed when the proposer for next_epoch_via_block was slashed. Therefore, I added a while loop to find the unslashed proposer.

@hwwhww hwwhww requested a review from ralexstokes May 6, 2023 13:43
@hwwhww hwwhww changed the title Fix test_randomized_state and test_randomized_state_leaking Fix process_inactivity_updates test cases May 6, 2023
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah!

@djrtwo djrtwo merged commit 9c35b73 into dev May 8, 2023
24 checks passed
@djrtwo djrtwo deleted the fix-tests branch May 8, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants