Move SUBNETS_PER_NODE from Constants to Configuration
#3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah. I thought it might be nice to have this flexibility so we can change it between networks which have different node-counts. It might make it easier for testnets with very-low node counts to function by increasing this parameter. |
djrtwo
reviewed
May 17, 2023
|
|
||
| | Name | Value | Unit | Duration | | ||
| | - | - | :-: | :-: | | ||
| | `SUBNETS_PER_NODE` | `2` | The number of long-lived subnets a beacon node should be subscribed to. | |
There was a problem hiding this comment.
I'm not sure this should go into validator.md. As it pertains to all nodes rather than just validator nodes
maybe in the p2p spec? what do you think
There was a problem hiding this comment.
Agreed. Hmm, I can move the whole "## Phase 0 attestation subnet stability" section to p2p spec.
There was a problem hiding this comment.
I ended up opening #3375 for it.
|
Should this be closed to avoid confusion? |
|
replaced by #3375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #3312 (comment),
This PR moves
SUBNETS_PER_NODEfrom "Constants" to "Configuration"./cc @AgeManning